Merge pull request #6 from XhmikosR/cppcheck

Minor code clean-up, by XhmikosR.
This commit is contained in:
LoRd_MuldeR 2015-04-09 20:58:44 +02:00
commit 3a8aea599d
7 changed files with 7 additions and 7 deletions

View File

@ -47,7 +47,7 @@ public:
int exec(void);
protected:
void CueImportDialog::showEvent(QShowEvent *event);
void showEvent(QShowEvent *event);
private slots:
void browseButtonClicked(void);

View File

@ -61,7 +61,7 @@ public:
void clearData(void);
//External API
int CueSheetModel::getFileCount(void);
int getFileCount(void);
QString getFileName(int fileIndex);
int getTrackCount(int fileIndex);
const AudioFileModel_MetaInfo *getTrackInfo(int fileIndex, int trackIndex);

View File

@ -69,7 +69,7 @@ public:
const QStringList &getLogFile(const QModelIndex &index) const;
const QUuid &getJobId(const QModelIndex &index) const;
const JobState getJobState(const QModelIndex &index) const;
const QIcon &ProgressModel::getIcon(ProgressModel::JobState state) const;
const QIcon &getIcon(ProgressModel::JobState state) const;
void restoreHiddenItems(void);
public slots:

View File

@ -52,5 +52,5 @@ private:
static playlist_t isPlaylist(const QString &fileName);
static void fixFilePath(QFileInfo &filename, const QDir &baseDir, const QDir &rootDir);
static QString &PlaylistImporter::unescapeXml(QString &str);
static QString &unescapeXml(QString &str);
};

View File

@ -36,5 +36,5 @@ class DecoderRegistry : public QObject
public:
static void configureDecoders(const SettingsModel *settings);
static AbstractDecoder *lookup(const QString &containerType, const QString &containerProfile, const QString &formatType, const QString &formatProfile, const QString &formatVersion);
static QStringList DecoderRegistry::getSupportedTypes(void);
static QStringList getSupportedTypes(void);
};

View File

@ -377,7 +377,7 @@ while(0)
} \
while(0)
void EncoderRegistry::saveEncoderCustomParams(SettingsModel *settings, const int encoderId, const QString params)
void EncoderRegistry::saveEncoderCustomParams(SettingsModel *settings, const int encoderId, const QString &params)
{
//Store the encoder bitrate/quality value
switch(encoderId)

View File

@ -42,7 +42,7 @@ public:
static void saveEncoderValue(SettingsModel *settings, const int encoderId, const int rcMode, const int value);
static int loadEncoderValue(const SettingsModel *settings, const int encoderId, const int rcMode);
static void saveEncoderCustomParams(SettingsModel *settings, const int encoderId, const QString params);
static void saveEncoderCustomParams(SettingsModel *settings, const int encoderId, const QString &params);
static QString loadEncoderCustomParams(const SettingsModel *settings, const int encoderId);
static void resetAllEncoders(SettingsModel *settings);